On Mon, Jun 1, 2026 at 3:50 PM Miguel Ojeda <[email protected]> wrote: > > By the way, I think a `.gitignore` entry for the generated header is missing.
A few other notes: - The `exports` rule' `awk` filtering is stricter than the one we normally use -- it is fine if you don't need `static`s etc., but I will likely export `T|R|D|B` when I replace it, not just `T`. - Similarly, you don't use `EXPORT_SYMBOL_RUST_GPL` and the "dummy symbol" is a function instead of the simple `int`. Is there a reason for that? i.e. the ones you want to export are functions, but using the global one (even defining `EXPORT_SYMBOL_RUST_GPL` the same way) would reduce the divergence (so one less thing to think about later when I replace it). - I noticed touching `nova-core` and then running a build twice will only build `nova-drm.ko` the second time -- you may want to use `--extern nova_core -L $(objtree)/...` like we do in `rust/Makefile` instead of giving an explicit path to `--extern`. I hope that helps! Cheers, Miguel
