On 04/06/2026 17:13, Rob Clark wrote: > On Thu, Jun 4, 2026 at 8:09 AM Krzysztof Kozlowski <[email protected]> wrote: >> >> On 04/06/2026 10:06, Konrad Dybcio wrote: >>> The Yoga Slim 7x Gen11 is a Snapdragon X2 Elite-based 14" laptop from >>> Lenovo, featuring an OLED touch panel. Add a compatible for it. >>> >>> According to the spec page [1], there also exist other variations >>> (based on the Mahua SoC and/or with a different type of display panel), >>> but those are to be described separately >>> >>> [1] https://psref.lenovo.com/Product/Yoga_Slim_7_14Q8Y11?tab=spec >>> Signed-off-by: Konrad Dybcio <[email protected]> >>> --- >>> Documentation/devicetree/bindings/arm/qcom.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml >>> b/Documentation/devicetree/bindings/arm/qcom.yaml >>> index >>> 50cc18a6ec5eddaf48542b85387c2d430cd4721a..fca3d180489d4cd3eb2726a722f15febe44f03ad >>> 100644 >>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >>> @@ -68,6 +68,7 @@ properties: >>> >>> - items: >>> - enum: >>> + - lenovo,yoga-slim7x-gen11 >> >> I imagine you might want different panel variants, just like T14s has >> LCD and OLED? > > I expect this will be the case.
Then better to prepare for this now, otherwise later you need to change bindings. If unsure what other variants are, then at least make this compatible panel-specific, e.g. lenovo,yoga-slim7x-gen11-oled-foo-bar. Adding fallback compatible is not usually incompatible ABI change, thus you can always do it later if needed. Best regards, Krzysztof
