Thank you for your contribution! Sashiko AI review found 1 potential issue(s) 
to consider:
- [Low] The newly added DT binding schema introduces a dtbs_check regression 
for an existing dummy panel node in 
`arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts`. The existing device 
tree uses `compatible = "boe,bf068mwm-td0"` for a simple-framebuffer dummy 
node, but lacks the strictly required properties mandated by the new schema.
--

commit 6315e592e65e15de511f78a600454fa1ddbaf9e2
Author: Alexander Koskovich <[email protected]>

dt-bindings: display: panel: Document Raydium RM69220 DDIC

Document the Raydium RM69220 DDIC and the BOE BF068MWM-TD0 6.77"
1080x2392 AMOLED display panel used in the Nothing Phone (3a).

> diff --git 
> a/Documentation/devicetree/bindings/display/panel/raydium,rm69220.yaml 
> b/Documentation/devicetree/bindings/display/panel/raydium,rm69220.yaml
> new file mode 100644
> index 0000000000000..7423b192d892c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm69220.yaml
[ ... ]
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - boe,bf068mwm-td0
> +      - const: raydium,rm69220

[Severity: Low]
Will this strict compatible requirement trigger dtbs_check failures for the
existing dummy panel node in
arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts?

That file currently uses this compatible string for a dummy node:

                        /* Dummy panel for simple-framebuffer dimension info */
                        panel: dummy-panel {
                                compatible = "boe,bf068mwm-td0";
                                height-mm = <157>;
                                width-mm = <71>;
                        };

Since the new schema mandates a two-item array with "raydium,rm69220" and
several other required properties like dvdd-supply, reg, and port, validating
the existing dts against this schema appears to cause validation failures.

Should the dummy node's compatible string be updated to avoid conflicting with
the actual hardware schema, or should the dts update be included in this
series?

-- 
Sashiko AI review ยท 
https://sashiko.dev/#/patchset/[email protected]?part=1

Reply via email to