Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Removing the trailing comma from macro invocations results in passing 3 arguments to a 4-argument macro, breaking the build. --
commit 4aa037560eff822608a285dbbf3f02e9ec0544be Author: Georgii Druzhinin <[email protected]> staging: fbtft: fbtft-bus: remove prohibited space before close parenthesis This commit attempts to resolve a checkpatch.pl formatting warning by removing what appears to be an empty argument and trailing comma from calls to the define_fbtft_write_reg macro. > diff --git a/drivers/staging/fbtft/fbtft-bus.c > b/drivers/staging/fbtft/fbtft-bus.c > index 30e436ff19e4c..409770891c548 100644 > --- a/drivers/staging/fbtft/fbtft-bus.c > +++ b/drivers/staging/fbtft/fbtft-bus.c [ ... ] > @@ -62,9 +62,9 @@ out: > \ > } > \ > EXPORT_SYMBOL(func); > > -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, ) > +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8) [Severity: Low] Does removing this comma break the build? The define_fbtft_write_reg macro is defined to take exactly four parameters: func, buffer_type, data_type, and modifier. By removing the trailing comma, only three arguments are passed to the macro. This will result in a preprocessor error for passing too few arguments. > define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16) > -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, ) > +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16) [Severity: Low] Will this invocation also fail to compile for the same missing argument reason? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
