Hi Timur, On Fri, Jun 05, 2026 at 06:22:41PM +0000, Timur Tabi wrote: > I think it would be cleaner to instead delete this > nvkm_firmware_put(blob) call here, and just rely on the call to > nvkm_firmware_put() at the end of nvkm_falcon_fw_ctor_hs(). Then you > won't need "blob = NULL".
Thanks for your review. I don't think we can drop the nvkm_firmware_put(blob) here. At this point, blob still points to the image firmware loaded at the beginning of nvkm_falcon_fw_ctor_hs(). The later nvkm_firmware_load_name(..., &blob) call overwrites blob with the bootloader firmware pointer on success. If we only rely on the final nvkm_firmware_put(blob), the success path would release the bootloader firmware, but the original image firmware pointer would be lost and leaked. Best regards, Dawei
