On Wed, Jun 10, 2026 at 03:32:12PM +0300, Jani Nikula wrote: > On Wed, 10 Jun 2026, Nicolas Frattaroli <[email protected]> > wrote: > > Having the test EDID arrays defined in the .h directly will duplicate > > them across every user of the EDID arrays. This works fine as long as > > there's only one user, but may produce build warnings/errors when there > > are multiple users and not all of them use all definitions. > > > > Move the array definitions to a new .c file, and mark the declarations > > in the header as "extern" to avoid the linker throwing a fit, and give > > them an explicit size (either 128 or 256, depending on EDID) to avoid > > the compiler inferring that they must be size 1. > > > > Reported-by: Jani Nikula <[email protected]> > > Closes: > > https://lore.kernel.org/r/[email protected]/ > > Fixes: ce1d0139adac ("drm/tests: bridge: Add test for HDMI output bus > > formats helper") > > Fixes: 082fbc179c01 ("drm/tests: bridge: Add KUnit tests for bridge chain > > format selection") > > Signed-off-by: Nicolas Frattaroli <[email protected]> > > Thanks for doing this. > > I think I would've also moved the comments with the edid-decode > results. Matter of taste I guess. > > Reviewed-by: Jani Nikula <[email protected]>
Yeah, I agree but since it fixes a compilation warning it can be done as a subsequent patch. Acked-by: Maxime Ripard <[email protected]> Maxime
signature.asc
Description: PGP signature
