ср, 10 черв. 2026 р. о 21:47 Andy Shevchenko <[email protected]> пише: > > On Wed, Jun 10, 2026 at 05:38:38PM +0300, Svyatoslav Ryhel wrote: > > вт, 9 черв. 2026 р. о 22:14 Andy Shevchenko <[email protected]> > > пише: > > > On Sat, Jun 06, 2026 at 07:57:31AM +0300, Svyatoslav Ryhel wrote: > > > > Switch from sysfs_create_group() to device_add_group() including device > > > > managed where appropriate. > > > > > > This should use .dev_groups member of struct device_driver. > > > > Specify pls, device_add_group literally uses dev_groups, I don't > > understand what is wrong. > > dev_groups of the struct device_driver. It means that the data should be > static and be available before driver probe is called. > > ... > > > > > + ret = devm_device_add_group(&bd->dev, &lm3533_bl_attribute_group); > > > > > > This will make Greg KH very grumpy. (For the record, original code as well > > > but it already is in upstream. So, thanks for trying to address this, just > > > needs a bit more of work.) > > > > In the prev iteration YOU asked to me to adjust this. I have adjusted > > and now you say that this is not appropriate. I will just drop this > > commit altogether. > > Yes, and I still tell that this is the way to fix that issue. > > You can even do it yourself in a few clicks (hint: `git log --grep` is the > tool > of the day): 93afe8ba9b01 ("ACPI: TAD: Use dev_groups in struct > device_driver"). > This is an example of what I meant. >
Oh, very nice, thanks! > > > > + if (ret < 0) > > > > + return dev_err_probe(&pdev->dev, ret, > > > > + "failed to create sysfs > > > > attributes\n"); > > -- > With Best Regards, > Andy Shevchenko > >
