Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Unnecessary header files were added to `xe_ras.c`. --
commit 5df465d682f75cd912c33257354af24edc73cf6d Author: Mallesh Koujalagi <[email protected]> drm/xe: Handle PUNIT errors by requesting cold-reset recovery When PUNIT (power management unit) errors are detected that persist across warm resets, mark the device as wedged with DRM_WEDGE_RECOVERY_COLD_RESET and notify userspace that a complete device power cycle is required to restore normal operation. > diff --git a/drivers/gpu/drm/xe/xe_ras.c b/drivers/gpu/drm/xe/xe_ras.c > index 6a5140bc47e52..93a56a0269f1e 100644 > --- a/drivers/gpu/drm/xe/xe_ras.c > +++ b/drivers/gpu/drm/xe/xe_ras.c > @@ -4,6 +4,8 @@ > */ > > #include "xe_bo.h" > +#include "xe_assert.h" > +#include "xe_device_types.h" [Severity: Low] Are these headers necessary here? Neither the new punit_error_handler() function nor the modified handle_soc_internal_errors() function appear to use any macros or types defined exclusively in xe_assert.h or xe_device_types.h. It looks like xe_device.h is already included below and provides the necessary types and function declarations like xe_device_set_wedged_method(). Could these additions be dropped to avoid unnecessary compilation dependencies? [ ... ] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=4
