On Mon Jun 8, 2026 at 1:34 PM CEST, Maxime Ripard wrote: > Hi, > > On Tue, May 19, 2026 at 12:37:21PM +0200, Luca Ceresoli wrote: >> Currently the struct drm_device pointer is only needed during the initial >> drm_bridge_connector_init() and in drm_bridge_connector_handle_hpd() which >> gets it from the struct drm_connector. >> >> This will be insufficient when introducing bridge hotplugging, because: >> >> * some of the actions in drm_bridge_connector_init() will have to be >> performed later on, when a bridge is hot(un)plugged >> * the connector will be removed and re-added based on hotplug events, >> so the drm_connector might just not exist or its content be cleared >> >> Store the drm_device pointer in struct drm_bridge_connector for any later >> needs. Also convert drm_bridge_connector_handle_hpd() to use the newly >> stored value. >> >> Signed-off-by: Luca Ceresoli <[email protected]> > > This is already accessible as drm_connector->dev and drm_bridge->dev. I > think it would be great to list why this is different, and how it is > different (ie, when it's set, unset).
With hotplug the drm_connector will be created dynamically, so it cannot be used. The drm_bridge->dev maybe. But we have a pointer to the encoder, which is supposed to be always present, so I'll try using next for v2. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
