*/ unsigned char __iomem *iop; + if (!request_mem_region(0x3000000, 0x5000, "cyber2000fb iop")) { + printk(KERN_ERR "iga5000: cannot reserve I/O area 0x3000000\n");pci_err() or pr_err() please.+ return -EBUSY; + } iop = ioremap(0x3000000, 0x5000); if (iop == NULL) { printk(KERN_ERR "iga5000: cannot map I/O\n");while at it, use pci_err() here too then. Helge
Hi Helge, I initially left the existing printk() usage unchanged to keep the patch focused on the memory resource reservation change and avoid unrelated churn. Since you've suggested updating the error reporting as well, I'll switch both messages to pci_err() in v2. Thanks for the review. Regards, Chintan
