Thank you for your contribution! Sashiko AI review found 1 potential issue(s) 
to consider:
- [Medium] Incomplete driver removal: only the Kconfig inclusion was removed, 
leaving orphaned source files, build entries, and documentation.
--

commit bf2996a15c0248854dd33c79b9ebac4018349692
Author: Gabriel Ramos Barbosa Mota <[email protected]>

staging: vme_user: remove obsolete VMEbus driver and Kconfig entry

This commit removes the Kconfig inclusion for the VMEbus driver in the
staging tree.

Closes: 
https://lore.kernel.org/oe-kbuild-all/[email protected]/

> diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
> index 2f92cd698bef6..0e6e5330fb6af 100644
> --- a/drivers/staging/Kconfig
> +++ b/drivers/staging/Kconfig
> @@ -46,6 +46,4 @@ source "drivers/staging/vc04_services/Kconfig"
>  
>  source "drivers/staging/axis-fifo/Kconfig"
>  
> -source "drivers/staging/vme_user/Kconfig"

[Severity: Medium]
The commit message indicates the driver is being removed, but this patch
only removes the Kconfig inclusion. Are there missing changes to remove
the driver's source files in drivers/staging/vme_user/ and its build
entry in drivers/staging/Makefile?

Additionally, should the references to the VME subsystem in MAINTAINERS
and the API documentation in Documentation/driver-api/vme.rst also be
cleaned up in this commit?

> -
>  endif # STAGING

-- 
Sashiko AI review ยท 
https://sashiko.dev/#/patchset/[email protected]?part=1

Reply via email to