在 2026-06-15一的 14:50 +0800，Joey Lu写道： > Register the Nuvoton MA35D1 DCUltraLite chip identity in > vs_chip_identities[]: > model = 0x0 (DCUltraLite; Verisilicon uses 0 for this IP) > revision = 0x5560 > customer_id = 0x305 > generation = VSDC_GEN_DC8000 > display_count = 1 > max_cursor_size = 32
I suggest make this more human-readable instead of replicating the machine-readable data of HWDB. My proposal here: ``` The Nuvoton MA35D1 chip contains a DCUltraLite display controller with model number 0x0 (sic, the model name contains no number either), revision 0x5560 and customer ID 0x305. It has a similar register map with DC8000, only one display output and only 32x32 cursor supported. ``` > > Placing this entry last makes it the gate that enables MA35D1 > hardware > recognition only after all the supporting ops and DT binding changes > are > in place. It's a little ambiguous that "last" here means whether the last in the patchset or the last in the HWDB array, although I think it's not so needed to explain the reason of the place in the patchset. I propose just say `Adding it to the HWDB to enable it to be usable with the verisilicon driver.` . > > Signed-off-by: Joey Lu <[email protected]> > --- > drivers/gpu/drm/verisilicon/vs_hwdb.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/verisilicon/vs_hwdb.c > b/drivers/gpu/drm/verisilicon/vs_hwdb.c > index 91524d16f778..7d630a667a3f 100644 > --- a/drivers/gpu/drm/verisilicon/vs_hwdb.c > +++ b/drivers/gpu/drm/verisilicon/vs_hwdb.c > @@ -129,6 +129,16 @@ static struct vs_chip_identity > vs_chip_identities[] = { > .max_cursor_size = 64, > .formats = &vs_formats_no_yuv444, > }, > + { > + .model = 0x0, /* DCUltraLite */ > + .revision = 0x5560, > + .customer_id = 0x305, > + > + .generation = VSDC_GEN_DC8000, > + .display_count = 1, > + .max_cursor_size = 32, > + .formats = &vs_formats_no_yuv444, > + }, > }; > > int vs_fill_chip_identity(struct regmap *regs,
