Amit Barzilai <[email protected]> writes: Hello Amit,
> Add a device tree binding for the Solomon SSD1351, a 128x128 65k-color > RGB OLED display controller driven over a 4-wire SPI bus. The binding > builds on the shared solomon,ssd-common.yaml properties already used by > the other Solomon display controllers. > > Assisted-by: Claude:claude-opus-4-8 > Signed-off-by: Amit Barzilai <[email protected]> > --- > Changes since v1: > - Drop solomon,width / solomon,height: both are deducible from the > compatible and are already declared (as optional) by the referenced > solomon,ssd-common.yaml, so a local override is unnecessary. > - Drop the rotation property: it has no consumer (rotation is being removed > from the driver). > - Use dt-bindings/gpio/gpio.h flag defines in the example > (reset-gpios active-low, dc-gpios active-high). > > .../bindings/display/solomon,ssd1351.yaml | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/solomon,ssd1351.yaml > > diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml > b/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml > new file mode 100644 > index 000000000000..39622d74a41d > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml > @@ -0,0 +1,41 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/solomon,ssd1351.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Solomon SSD1351 OLED Display Controller > + > +maintainers: > + - Amit Barzilai <[email protected]> > + Feel free to add me as a maintainer of this binding too since I maintain the ssd130x driver. It looks good to me. Reviewed-by: Javier Martinez Canillas <[email protected]> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
