Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] The updated help text for `SYSFB_SIMPLEFB` incorrectly claims that `efidrm` and `vesadrm` can act as fallbacks when `SYSFB_SIMPLEFB` is enabled. - [Medium] Incomplete deprecation leads to conflicting Kconfig instructions for `SYSFB_SIMPLEFB` and `DRM_SIMPLEDRM`. --
commit 5ea287d9e1ed6b65c8ad4f43e0319a4e41d57b15 Author: Thomas Zimmermann <[email protected]> firmware: sysfb: Mark CONFIG_SYSFB_SIMPLEFB as deprecated This commit marks CONFIG_SYSFB_SIMPLEFB as deprecated. Enabling it allows to run simpledrm and simplefb on EFI/VESA framebuffers, which is now discouraged in favor of using efidrm and vesadrm. > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > index 12dc70254842c..dea907178e4ad 100644 > --- a/drivers/firmware/Kconfig > +++ b/drivers/firmware/Kconfig > @@ -187,32 +187,23 @@ config SYSFB > select SCREEN_INFO > > config SYSFB_SIMPLEFB > - bool "Mark VGA/VBE/EFI FB as generic system framebuffer" > + bool "Mark VGA/VBE/EFI FB as generic system framebuffer (deprecated)" > depends on X86 || EFI > select SYSFB > help [ ... ] > + This option, if enabled, marks VBE/EFI framebuffers as system > + framebuffers so the generic simpledrm driver can be used. If the > + framebuffer is not compatible with the generic modes, it is > + advertised as fallback platform framebuffer so regular drivers like > + efidrm, vesadrm can pick it up. [Severity: Medium] Is this fallback behavior accurate for efidrm and vesadrm? Looking at DRM_EFIDRM in drivers/gpu/drm/sysfb/Kconfig, it has a mutual exclusion dependency: config DRM_EFIDRM depends on DRM && MMU && EFI && (!SYSFB_SIMPLEFB || COMPILE_TEST) Since both DRM_EFIDRM and DRM_VESADRM depend on !SYSFB_SIMPLEFB, it appears they cannot be enabled alongside SYSFB_SIMPLEFB in a standard build to act as fallbacks. > + > + This option is deprecated and will be removed in the near future. If > + unsure, say N and select efidrm, vesadrm instead. The dedicated DRM > + drivers provide the same functionality plus additional features. [Severity: Medium] Does the DRM_SIMPLEDRM documentation also need an update to resolve a conflict with this deprecation? While this instructs users to say N to SYSFB_SIMPLEFB, the help text for DRM_SIMPLEDRM in drivers/gpu/drm/sysfb/Kconfig still explicitly instructs users to select it: config DRM_SIMPLEDRM help ... On x86 BIOS or UEFI systems, you should also select SYSFB_SIMPLEFB to use UEFI and VESA framebuffers. Leaving the DRM_SIMPLEDRM help text unmodified might leave users with conflicting instructions on how to configure system framebuffers. > > config TH1520_AON_PROTOCOL > tristate "Always-On firmware protocol" -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
