umc_v12_0_fill_error_record() returns ret after walking the pages reported by amdgpu_umc_lookup_bad_pages_in_a_row(). That helper can return zero, including when its temporary allocation fails, leaving the loop skipped and ret uninitialized.
Initialize ret to 0 so the zero-page path reports a deterministic status instead of returning stack data. Signed-off-by: Ruoyu Wang <[email protected]> --- drivers/gpu/drm/amd/amdgpu/umc_v12_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v12_0.c b/drivers/gpu/drm/amd/amdgpu/umc_v12_0.c index 14092150336a5..77a9f6a47d428 100644 --- a/drivers/gpu/drm/amd/amdgpu/umc_v12_0.c +++ b/drivers/gpu/drm/amd/amdgpu/umc_v12_0.c @@ -681,7 +681,7 @@ static int umc_v12_0_fill_error_record(struct amdgpu_device *adev, { struct ras_err_data *err_data = (struct ras_err_data *)ras_error_status; uint64_t page_pfn[UMC_V12_0_BAD_PAGE_NUM_PER_CHANNEL]; - int ret, i, count; + int ret = 0, i, count; if (!err_data || !ecc_err) return -EINVAL; -- 2.51.0
