On Sat, Jun 20, 2026 at 09:23:14PM +0200, Christophe JAILLET wrote: > The resource freed at the 'put_aux' label is "sor->aux->dev". > However, this resource is taken after devm_tegra_pmc_get(), so there is no > point to release it in this error handling path. > > This is harmless because put_device() will be called with a NULL pointer, > but this is confusing. > > So, fix the logic and return directly. > > Signed-off-by: Christophe JAILLET <[email protected]> > --- > Compile tested only. > > This is not a bug, so no need for a Fixes tag. > If needed anyway, it was introduced by commit e68c4244136b ("drm/tegra: > Explicitly specify PMC instance to use") > --- > drivers/gpu/drm/tegra/sor.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-)
Good catch! Looks like I used the put_aux label without realizing that sor->aux isn't acquired until *after* sor->pmc here. Thanks for fixing this, Thierry
signature.asc
Description: PGP signature
