On Mon, Jun 22, 2026 at 03:23:05PM +0200, Krzysztof Kozlowski wrote: > On 22/06/2026 12:19, [email protected] wrote: > > Thank you for your contribution! Sashiko AI review found 1 potential > > issue(s) to consider: > > - [Low] Unintended replacement of BNF notation `::=` with `:=`. > > -- > > > > commit a9fdd0b065eb5b6394a9c33ffba0fd5194e80115 > > Author: Krzysztof Kozlowski <[email protected]> > > > > dt-bindings: Drop incorrect usage of double '::' > > > > This commit cleans up device tree binding schemas by removing the redundant > > double colons at the end of descriptions inside YAML literal style blocks. > > > > Link: https://yaml.org/spec/1.2.2/#literal-style [1] > > > >> diff --git a/Documentation/devicetree/bindings/mux/mux-consumer.yaml > >> b/Documentation/devicetree/bindings/mux/mux-consumer.yaml > >> index 9e2d78a78e409..769243a2bf046 100644 > >> --- a/Documentation/devicetree/bindings/mux/mux-consumer.yaml > >> +++ b/Documentation/devicetree/bindings/mux/mux-consumer.yaml > >> @@ -13,8 +13,8 @@ description: | > >> Mux controller consumers should specify a list of mux controllers that > >> they > >> want to use with a property containing a 'mux-ctrl-list': > >> > >> - mux-ctrl-list ::= <single-mux-ctrl> [mux-ctrl-list] > >> - single-mux-ctrl ::= <mux-ctrl-phandle> [mux-ctrl-specifier] > >> + mux-ctrl-list := <single-mux-ctrl> [mux-ctrl-list] > >> + single-mux-ctrl := <mux-ctrl-phandle> [mux-ctrl-specifier] > > > > [Severity: Low] > > Does this unintentionally change the standard Backus-Naur Form (BNF) ::= > > operator to :=? It looks like a global search-and-replace for :: might > > > I wasn't sure about that... and indeed this should not be changed. I > will send a v2.
Other than this one that I agree shouldn't be changed to a single :, Acked-by: Conor Dooley <[email protected]> (Although I find the syntax used here to be really confusing and a good example in the text would be a lot clearer. OTOH, how to write consumers is, I think, well understood, since they all work the same.)
signature.asc
Description: PGP signature
