On Thu, 21 May 2026 10:36:28 +0200, Bartosz Golaszewski <[email protected]> said: > Platform devices created with platform_device_alloc() call > platform_device_release() when the last reference to the device's > kobject is dropped. This function calls of_node_put() unconditionally. > This works fine for devices created with platform_device_register_full() > but users of the split approach (platform_device_alloc() + > platform_device_add()) must bump the reference of the of_node they > assign manually. Add the missing call to of_node_get(). > > Cc: [email protected] > Fixes: 81e5d8646ff6 ("i2c/powermac: Register i2c devices from device-tree") > Signed-off-by: Bartosz Golaszewski <[email protected]> > --- > arch/powerpc/platforms/powermac/low_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/powermac/low_i2c.c > b/arch/powerpc/platforms/powermac/low_i2c.c > index > da72a30ab8657e6dc7e6f3437af612155783d8f9..973f58771d9636605ed5d3e91b45008543b584d3 > 100644 > --- a/arch/powerpc/platforms/powermac/low_i2c.c > +++ b/arch/powerpc/platforms/powermac/low_i2c.c > @@ -1471,7 +1471,7 @@ static int __init pmac_i2c_create_platform_devices(void) > if (bus->platform_dev == NULL) > return -ENOMEM; > bus->platform_dev->dev.platform_data = bus; > - bus->platform_dev->dev.of_node = bus->busnode; > + bus->platform_dev->dev.of_node = of_node_get(bus->busnode); > platform_device_add(bus->platform_dev); > } > > > -- > 2.47.3 > >
Madhavan, can you please pick this up and send it upstream as a fix please? Not having to carry it with the rest of the series will make things easier for the next release. Thanks, Bartosz
