Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Broken intra-doc link for `FalconModSelAlgo` causes rustdoc build failures. --
commit 38e6d24ce9170693f7e3057866f61c8d872b90e3 Author: Antonin Malzieu Ridolfi <[email protected]> gpu: nova-core: falcon: Move PFALCON2 register This commit moves the PFALCON2 register definition into the falcon module and updates register visibility. > diff --git a/drivers/gpu/nova-core/falcon.rs b/drivers/gpu/nova-core/falcon.rs > index 94c7696a64935..c2215ddd9e804 100644 > --- a/drivers/gpu/nova-core/falcon.rs > +++ b/drivers/gpu/nova-core/falcon.rs [ ... ] > @@ -99,7 +99,7 @@ pub(crate) enum FalconSecurityModel with > TryFrom<Bounded<u32, 2>> { > > bounded_enum! { > /// Signing algorithm for a given firmware, used in the > - /// [`crate::regs::NV_PFALCON2_FALCON_MOD_SEL`] register. It is passed > to the Falcon Boot ROM > + /// [`super::regs::NV_PFALCON2_FALCON_MOD_SEL`] register. It is passed > to the Falcon Boot ROM [Severity: Low] This isn't a bug, but does this create a broken intra-doc link for rustdoc? Since this enum is in the falcon module, super::regs would resolve to crate::regs, but the register definition was just moved into the falcon module. Would it be better to use regs::NV_PFALCON2_FALCON_MOD_SEL instead to prevent rustdoc build warnings or failures? > /// (BROM) as a parameter. > #[derive(Debug, Copy, Clone)] > pub(crate) enum FalconModSelAlgo with TryFrom<Bounded<u32, 8>> { -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=3
