Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] DRM_PANEL_VISIONOX_VTDR6130 selects DRM_DISPLAY_DSC_HELPER without selecting its dependency DRM_DISPLAY_HELPER, causing Kconfig warnings and linker errors. --
commit 907cf541c38810dd47d3b40db2c3237ed1d8ffd9 Author: Jun Nie <[email protected]> drm/panel: Enable DSC for Visionox VTDR6130 panel This commit enables display compression (DSC v1.2) for the 1080x2400 Visionox VTDR6130 AMOLED DSI panel. > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index c0cc2bb4a3eb7..298c08f293260 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -1352,6 +1352,7 @@ config DRM_PANEL_VISIONOX_VTDR6130 > depends on OF > depends on DRM_MIPI_DSI > depends on BACKLIGHT_CLASS_DEVICE > + select DRM_DISPLAY_DSC_HELPER [Severity: Low] Does this selection also require selecting or depending on DRM_DISPLAY_HELPER? If a user configures the kernel with CONFIG_DRM_PANEL_VISIONOX_VTDR6130=y but does not enable CONFIG_DRM_DISPLAY_HELPER, Kconfig can emit an unmet direct dependency warning. This can lead to a linker error for missing DSC helper functions like drm_dsc_pps_payload_pack(), since drm_dsc_helper.o is built as part of drm_display_helper-y and is only linked if CONFIG_DRM_DISPLAY_HELPER is enabled. > help > Say Y here if you want to enable support for Visionox > VTDR6130 1080x2400 AMOLED DSI panel. [ ... ] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
