在 2026-06-29一的 05:35 +0000，[email protected]写道： > Thank you for your contribution! Sashiko AI review found 1 potential > issue(s) to consider: > - [Low] The commit message incorrectly states that the controller > requires 'two reset lines', while the actual binding schema and > examples define three reset lines ('core', 'axi', 'ahb'). > -- > > commit 11712ddd9a2861c41656c6eb9cdbd525c93e3665 > Author: Icenowy Zheng <[email protected]> > > dt-bindings: display: verisilicon, dc: make resets non-optional > > This commit makes the resets and reset-names properties mandatory for > the > DC8200 controller variant. The commit message notes that the in-tree > device tree already populates these lines and the driver handles them > gracefully if missing in other variants. > > > The only variant supported by the binding now, the DC8200 > > controller on > > T-Head TH1520, requires two reset lines. > > [Severity: Low] > Is the description of "two reset lines" accurate here? > > Looking at the existing schema in verisilicon,dc.yaml under the > resets > property, it defines three reset items (DC Core reset, DMA AXI bus > reset, > and Configuration AHB bus reset). Should the commit message mention > three > resets instead of two?
Thanks for this tip, it seems that my memory in brain bitfilpped and this deserves a fix. Thanks, Icenowy
