On 2026-06-29 at 17:09 +1000, Alexandre Courbot <[email protected]> wrote... > On Mon Jun 29, 2026 at 2:55 PM JST, SeungJong Ha wrote: > > On Mon Jun 29, 2026 at 2:52 AM UTC, Alistair Popple wrote: > >> Given the inevitable conflicts that will arise from trying to merge several > >> different series doing bits of the same thing I'm happy if someone wants > >> to take > >> this patch and the others and roll them into a single series. > >> Alternatively I am > >> happy to take that on - hopefully Alex can provide some guidance here for > >> what > >> would be preferred. > > > > Agreed it should be one series. Happy to help or fold in my part -- > > whatever Alex prefers. > > Since there is no particular urgency to switch from transmute to > zerocopy, I think it makes sense to merge things in an order that limits > churn as much as possible. > > This means the conversion should probably be done bottom-to-top, > starting with the bindings, then the types that embed them. For the > bindings, `#[derive(zerocopy_derive::most_traits)]` should be landing > soon [1] and I would like us to understand first whether that is > something we want to use with the bindings; if so, let's wait for it to > be available (unless there is a good reason to convert quickly) as each > change to `bindings.rs` is almost 200 LoCs.
I think it makes sense to wait, if only to avoid churn on the generated bindings. > Since Alistair maintains the tool generating the bindings [2], I think > it would make sense if he takes care of that part (bindings and anything > embedding them) as well. Agreed. > There are also types in nova-core that do not depend on bindings at all; > for these I think it is fine to take the patches that have been already > submitted if they apply cleanly and build, as these are good > opportunities for first contributions. Nicolás was first to send > something for vbios/firmware [3] so I'd like to consider his v2 first > now that `-rc1` is tagged. Yep - given the interest from other contributors I'm going to leave all the non-binding related conversions alone. In other words anything that does not require changes to drivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs would be good for others to look at, and thanks for the contributions! - Alistair > For the rest, I'm happy to merge anything that applies - small patches > limited to a single module should be easier to process and less likely > to conflict. > > [1] https://lore.kernel.org/all/[email protected]/ > [2] https://github.com/apopple-nvidia/nova-gsp-binding-generator/ > [3] > https://lore.kernel.org/all/[email protected]/
