Re: [PATCH v3 6/7] drm/of: Implement drm_of_get_panel_orientation()

Mon, 29 Jun 2026 05:45:18 -0700 

Hi

Am 29.06.26 um 14:27 schrieb Thierry Reding:

On Thu, Jun 25, 2026 at 11:39:38AM +0200, Thomas Zimmermann wrote:

Implement drm_of_get_panel_orientation() to retrieve a panel's
rotation property as enum drm_panel_orientation. The code has
been taken from of_drm_get_panel_orientation(), so convert that
helper over. Callers of the old helper can be converted as well.

Signed-off-by: Thomas Zimmermann <[email protected]>
---
  drivers/gpu/drm/drm_of.c    | 44 +++++++++++++++++++++++++++++++++++++
  drivers/gpu/drm/drm_panel.c | 26 ++--------------------
  include/drm/drm_of.h        | 11 ++++++++++
  3 files changed, 57 insertions(+), 24 deletions(-)

So you're effectively renaming of_drm_get_panel_orientation() to
drm_of_get_panel_orientation(), while moving it to drm_of.c,  and then
you keep of_drm_get_panel_orientation() as an alias.

I don't understand the use of this. Maybe if we really need to move this
out of drm_panel.c to make it more widely available, fine. Maybe we also
want the drm_of_ prefix instead of of_drm_, also fine, I suppose. But in
that case we should just go ahead and update all callers of the old
helper and get rid of it while we're at it. No use in keeping around
aliases/duplicates.


I'm all for it. i though this would be a different issue.



I've attached a patch to do just that. Feel free to integrate it into
the series, or we can apply after your series is merged.


Thanks.
Let me split of the  first 5 patches in series and merge them. They are the fixes and hardening patches and seem ready to be merged. I'll prepare a separate series for the panel orientation with your changes and it can go in separately. If we touch all the panel drivers, we should make sure that the panel maintainers get another chance of looking over it. 

Best regards
Thomas



Thierry

 From 2aabb20fd3c8666fd9a8635e28cf6e398de7e717 Mon Sep 17 00:00:00 2001
From: Thierry Reding <[email protected]>
Date: Mon, 29 Jun 2026 14:23:27 +0200
Subject: [PATCH] drm/panel: Use drm_of_get_panel_orientation()

The old of_drm_get_panel_orientation() function was replaced by the
drm_of_get_panel_orientation() in the core DRM OF helpers. Replace all
uses of the old helper and remove it.

Signed-off-by: Thierry Reding <[email protected]>
---
  drivers/gpu/drm/drm_panel.c                   | 20 -------------------
  .../drm/panel/panel-boe-th101mb31ig002-28a.c  |  2 +-
  .../gpu/drm/panel/panel-boe-tv101wum-nl6.c    |  2 +-
  .../gpu/drm/panel/panel-chipwealth-ch13726a.c |  2 +-
  drivers/gpu/drm/panel/panel-edp.c             |  2 +-
  drivers/gpu/drm/panel/panel-elida-kd35t133.c  |  2 +-
  .../gpu/drm/panel/panel-focaltech-ota7290b.c  |  2 +-
  drivers/gpu/drm/panel/panel-himax-hx83102.c   |  2 +-
  drivers/gpu/drm/panel/panel-himax-hx8394.c    |  2 +-
  .../gpu/drm/panel/panel-ilitek-ili9806e-dsi.c |  2 +-
  drivers/gpu/drm/panel/panel-ilitek-ili9881c.c |  2 +-
  drivers/gpu/drm/panel/panel-ilitek-ili9882t.c |  2 +-
  .../gpu/drm/panel/panel-jadard-jd9365da-h3.c  |  2 +-
  drivers/gpu/drm/panel/panel-lvds.c            |  2 +-
  drivers/gpu/drm/panel/panel-novatek-nt36523.c |  2 +-
  drivers/gpu/drm/panel/panel-simple.c          |  2 +-
  drivers/gpu/drm/panel/panel-sitronix-st7701.c |  2 +-
  drivers/gpu/drm/panel/panel-sitronix-st7703.c |  2 +-
  .../gpu/drm/panel/panel-sitronix-st7789v.c    |  2 +-
  include/drm/drm_panel.h                       |  8 --------
  20 files changed, 18 insertions(+), 46 deletions(-)

diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c
index eddd13a34c03..d7c6f4824b2d 100644
--- a/drivers/gpu/drm/drm_panel.c
+++ b/drivers/gpu/drm/drm_panel.c
@@ -492,26 +492,6 @@ struct drm_panel *of_drm_find_panel(const struct 
device_node *np)
        return ERR_PTR(-EPROBE_DEFER);
  }
  EXPORT_SYMBOL(of_drm_find_panel);
-
-/**
- * of_drm_get_panel_orientation - look up the orientation of the panel through
- * the "rotation" binding from a device tree node
- * @np: device tree node of the panel
- * @orientation: orientation enum to be filled in
- *
- * Looks up the rotation of a panel in the device tree. The orientation of the
- * panel is expressed as a property name "rotation" in the device tree. The
- * rotation in the device tree is counter clockwise.
- *
- * Return: 0 when a valid rotation value (0, 90, 180, or 270) is read or the
- * rotation property doesn't exist. Return a negative error code on failure.
- */
-int of_drm_get_panel_orientation(const struct device_node *np,
-                                enum drm_panel_orientation *orientation)
-{
-       return drm_of_get_panel_orientation(np, orientation);
-}
-EXPORT_SYMBOL(of_drm_get_panel_orientation);
  #endif
/* Find panel by fwnode. This should be identical to of_drm_find_panel(). */ 
diff --git a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c 
b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
index 01b4458e55ad..6a77c2256fd5 100644
--- a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
+++ b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
@@ -380,7 +380,7 @@ static int boe_th101mb31ig002_dsi_probe(struct 
mipi_dsi_device *dsi)
                return dev_err_probe(&dsi->dev, PTR_ERR(ctx->reset),
                                     "Failed to get reset GPIO\n");
- ret = of_drm_get_panel_orientation(dsi->dev.of_node, 
+       ret = drm_of_get_panel_orientation(dsi->dev.of_node,
                                           &ctx->orientation);
        if (ret)
                return dev_err_probe(&dsi->dev, ret,
diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c 
b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
index 658ce64c71eb..8f2de17b8b2b 100644
--- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
+++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
@@ -1722,7 +1722,7 @@ static int boe_panel_add(struct boe_panel *boe)
boe->base.prepare_prev_first = true; - err = of_drm_get_panel_orientation(dev->of_node, &boe->orientation); 
+       err = drm_of_get_panel_orientation(dev->of_node, &boe->orientation);
        if (err < 0) {
                dev_err(dev, "%pOF: failed to get orientation %d\n", 
dev->of_node, err);
                return err;
diff --git a/drivers/gpu/drm/panel/panel-chipwealth-ch13726a.c 
b/drivers/gpu/drm/panel/panel-chipwealth-ch13726a.c
index be76bc825c3f..437ee2294a9a 100644
--- a/drivers/gpu/drm/panel/panel-chipwealth-ch13726a.c
+++ b/drivers/gpu/drm/panel/panel-chipwealth-ch13726a.c
@@ -268,7 +268,7 @@ static int ch13726a_probe(struct mipi_dsi_device *dsi)
                return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio),
                                     "Failed to get reset-gpios\n");
- ret = of_drm_get_panel_orientation(dev->of_node, &ctx->orientation); 
+       ret = drm_of_get_panel_orientation(dev->of_node, &ctx->orientation);
        if (ret < 0) {
                dev_err(dev, "%pOF: failed to get orientation %d\n", 
dev->of_node, ret);
                return ret;
diff --git a/drivers/gpu/drm/panel/panel-edp.c 
b/drivers/gpu/drm/panel/panel-edp.c
index aa27d6cd932e..9af908811cf7 100644
--- a/drivers/gpu/drm/panel/panel-edp.c
+++ b/drivers/gpu/drm/panel/panel-edp.c
@@ -865,7 +865,7 @@ static int panel_edp_probe(struct device *dev, const struct 
panel_desc *desc,
                return dev_err_probe(dev, PTR_ERR(panel->enable_gpio),
                                     "failed to request GPIO\n");
- err = of_drm_get_panel_orientation(dev->of_node, &panel->orientation); 
+       err = drm_of_get_panel_orientation(dev->of_node, &panel->orientation);
        if (err) {
                dev_err(dev, "%pOF: failed to get orientation %d\n", 
dev->of_node, err);
                return err;
diff --git a/drivers/gpu/drm/panel/panel-elida-kd35t133.c 
b/drivers/gpu/drm/panel/panel-elida-kd35t133.c
index 1f177834d629..5565f7a63fd5 100644
--- a/drivers/gpu/drm/panel/panel-elida-kd35t133.c
+++ b/drivers/gpu/drm/panel/panel-elida-kd35t133.c
@@ -233,7 +233,7 @@ static int kd35t133_probe(struct mipi_dsi_device *dsi)
                return ret;
        }
- ret = of_drm_get_panel_orientation(dev->of_node, &ctx->orientation); 
+       ret = drm_of_get_panel_orientation(dev->of_node, &ctx->orientation);
        if (ret < 0) {
                dev_err(dev, "%pOF: failed to get orientation %d\n", 
dev->of_node, ret);
                return ret;
diff --git a/drivers/gpu/drm/panel/panel-focaltech-ota7290b.c 
b/drivers/gpu/drm/panel/panel-focaltech-ota7290b.c
index ed02a8daf96f..b6c5bf3977ee 100644
--- a/drivers/gpu/drm/panel/panel-focaltech-ota7290b.c
+++ b/drivers/gpu/drm/panel/panel-focaltech-ota7290b.c
@@ -181,7 +181,7 @@ static int ota7290b_probe(struct mipi_dsi_device *dsi)
                return dev_err_probe(&dsi->dev, PTR_ERR(ctx->vdd),
                                        "Couldn't get our VDD supply\n");
- ret = of_drm_get_panel_orientation(dsi->dev.of_node, &ctx->orientation); 
+       ret = drm_of_get_panel_orientation(dsi->dev.of_node, &ctx->orientation);
        if (ret) {
                dev_err(&dsi->dev, "%pOF: failed to get orientation: %d\n",
                        dsi->dev.of_node, ret);
diff --git a/drivers/gpu/drm/panel/panel-himax-hx83102.c 
b/drivers/gpu/drm/panel/panel-himax-hx83102.c
index d7e5664a5838..d61d68c1a2e7 100644
--- a/drivers/gpu/drm/panel/panel-himax-hx83102.c
+++ b/drivers/gpu/drm/panel/panel-himax-hx83102.c
@@ -1264,7 +1264,7 @@ static int hx83102_panel_add(struct hx83102 *ctx)
ctx->base.prepare_prev_first = true; - err = of_drm_get_panel_orientation(dev->of_node, &ctx->orientation); 
+       err = drm_of_get_panel_orientation(dev->of_node, &ctx->orientation);
        if (err < 0)
                return dev_err_probe(dev, err, "failed to get orientation\n");
diff --git a/drivers/gpu/drm/panel/panel-himax-hx8394.c b/drivers/gpu/drm/panel/panel-himax-hx8394.c 
index bf80354567df..8c830f929d73 100644
--- a/drivers/gpu/drm/panel/panel-himax-hx8394.c
+++ b/drivers/gpu/drm/panel/panel-himax-hx8394.c
@@ -992,7 +992,7 @@ static int hx8394_probe(struct mipi_dsi_device *dsi)
                return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio),
                                     "Failed to get reset gpio\n");
- ret = of_drm_get_panel_orientation(dev->of_node, &ctx->orientation); 
+       ret = drm_of_get_panel_orientation(dev->of_node, &ctx->orientation);
        if (ret < 0) {
                dev_err(dev, "%pOF: failed to get orientation %d\n", 
dev->of_node, ret);
                return ret;
diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c 
b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c
index ecdbed8d4a3a..c9241796e1a3 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c
@@ -132,7 +132,7 @@ static int ili9806e_dsi_probe(struct mipi_dsi_device *dsi)
        dsi->format = ctx->desc->format;
        dsi->lanes = ctx->desc->lanes;
- ret = of_drm_get_panel_orientation(dev->of_node, &ctx->orientation); 
+       ret = drm_of_get_panel_orientation(dev->of_node, &ctx->orientation);
        if (ret)
                return dev_err_probe(dev, ret, "Failed to get orientation\n");
diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c 
index 0652cdb57d11..a13fe1bb3e46 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
@@ -2571,7 +2571,7 @@ static int ili9881c_dsi_probe(struct mipi_dsi_device *dsi)
                return dev_err_probe(&dsi->dev, PTR_ERR(ctx->reset),
                                     "Couldn't get our reset GPIO\n");
- ret = of_drm_get_panel_orientation(dsi->dev.of_node, &ctx->orientation); 
+       ret = drm_of_get_panel_orientation(dsi->dev.of_node, &ctx->orientation);
        if (ret) {
                dev_err(&dsi->dev, "%pOF: failed to get orientation: %d\n",
                        dsi->dev.of_node, ret);
diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c 
b/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c
index 5f4e0d82ee67..613ecd1fbdd6 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c
@@ -795,7 +795,7 @@ static int ili9882t_add(struct ili9882t *ili)
gpiod_set_value_cansleep(ili->enable_gpio, 0); - err = of_drm_get_panel_orientation(dev->of_node, &ili->orientation); 
+       err = drm_of_get_panel_orientation(dev->of_node, &ili->orientation);
        if (err < 0) {
                dev_err(dev, "%pOF: failed to get orientation %d\n", 
dev->of_node, err);
                return err;
diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c 
b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
index f6b04de1182e..67ef9e0fea03 100644
--- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
+++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
@@ -2992,7 +2992,7 @@ static int jadard_dsi_probe(struct mipi_dsi_device *dsi)
                return dev_err_probe(&dsi->dev, PTR_ERR(jadard->vccio),
                                "failed to get vccio regulator\n");
- ret = of_drm_get_panel_orientation(dev->of_node, &jadard->orientation); 
+       ret = drm_of_get_panel_orientation(dev->of_node, &jadard->orientation);
        if (ret < 0)
                return dev_err_probe(dev, ret, "failed to get orientation\n");
diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c 
index 46b07f38559f..37f7498449ec 100644
--- a/drivers/gpu/drm/panel/panel-lvds.c
+++ b/drivers/gpu/drm/panel/panel-lvds.c
@@ -126,7 +126,7 @@ static int panel_lvds_parse_dt(struct panel_lvds *lvds)
        struct device_node *np = lvds->dev->of_node;
        int ret;
- ret = of_drm_get_panel_orientation(np, &lvds->orientation); 
+       ret = drm_of_get_panel_orientation(np, &lvds->orientation);
        if (ret < 0) {
                dev_err(lvds->dev, "%pOF: failed to get orientation %d\n", np, 
ret);
                return ret;
diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36523.c 
b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
index 226d91daf8c7..100816b04c13 100644
--- a/drivers/gpu/drm/panel/panel-novatek-nt36523.c
+++ b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
@@ -1206,7 +1206,7 @@ static int nt36523_probe(struct mipi_dsi_device *dsi)
        pinfo->dsi[0] = dsi;
        mipi_dsi_set_drvdata(dsi, pinfo);
- ret = of_drm_get_panel_orientation(dev->of_node, &pinfo->orientation); 
+       ret = drm_of_get_panel_orientation(dev->of_node, &pinfo->orientation);
        if (ret < 0) {
                dev_err(dev, "%pOF: failed to get orientation %d\n", 
dev->of_node, ret);
                return ret;
diff --git a/drivers/gpu/drm/panel/panel-simple.c 
b/drivers/gpu/drm/panel/panel-simple.c
index c09bf3db5e78..5c169fdf265c 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -693,7 +693,7 @@ static struct panel_simple *panel_simple_probe(struct 
device *dev)
                return dev_err_cast_probe(dev, panel->enable_gpio,
                                          "failed to request GPIO\n");
- err = of_drm_get_panel_orientation(dev->of_node, &panel->orientation); 
+       err = drm_of_get_panel_orientation(dev->of_node, &panel->orientation);
        if (err) {
                dev_err(dev, "%pOF: failed to get orientation %d\n", 
dev->of_node, err);
                return ERR_PTR(err);
diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7701.c 
b/drivers/gpu/drm/panel/panel-sitronix-st7701.c
index 2f79ec4a2063..11c757752cfb 100644
--- a/drivers/gpu/drm/panel/panel-sitronix-st7701.c
+++ b/drivers/gpu/drm/panel/panel-sitronix-st7701.c
@@ -1296,7 +1296,7 @@ static int st7701_probe(struct device *dev, int 
connector_type)
                return PTR_ERR(st7701->reset);
        }
- ret = of_drm_get_panel_orientation(dev->of_node, &st7701->orientation); 
+       ret = drm_of_get_panel_orientation(dev->of_node, &st7701->orientation);
        if (ret < 0)
                return dev_err_probe(dev, ret, "Failed to get orientation\n");
diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c 
index 6c348fe28955..40df2e5b14b2 100644
--- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c
+++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
@@ -874,7 +874,7 @@ static int st7703_probe(struct mipi_dsi_device *dsi)
                return dev_err_probe(dev, PTR_ERR(ctx->iovcc),
                                     "Failed to request iovcc regulator\n");
- ret = of_drm_get_panel_orientation(dsi->dev.of_node, &ctx->orientation); 
+       ret = drm_of_get_panel_orientation(dsi->dev.of_node, &ctx->orientation);
        if (ret < 0)
                return dev_err_probe(&dsi->dev, ret, "Failed to get 
orientation\n");
diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c 
index d5f821d6b23c..0502df34746b 100644
--- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
+++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
@@ -646,7 +646,7 @@ static int st7789v_probe(struct spi_device *spi)
        if (ret)
                return dev_err_probe(dev, ret, "Failed to get backlight\n");
- ret = of_drm_get_panel_orientation(spi->dev.of_node, &ctx->orientation); 
+       ret = drm_of_get_panel_orientation(spi->dev.of_node, &ctx->orientation);
        if (ret)
                return dev_err_probe(&spi->dev, ret, "Failed to get 
orientation\n");
diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h 
index 86b3f9c65c92..b87323443f49 100644
--- a/include/drm/drm_panel.h
+++ b/include/drm/drm_panel.h
@@ -337,19 +337,11 @@ int drm_panel_get_modes(struct drm_panel *panel, struct 
drm_connector *connector
#if defined(CONFIG_OF) && defined(CONFIG_DRM_PANEL) 
  struct drm_panel *of_drm_find_panel(const struct device_node *np);
-int of_drm_get_panel_orientation(const struct device_node *np,
-                                enum drm_panel_orientation *orientation);
  #else
  static inline struct drm_panel *of_drm_find_panel(const struct device_node 
*np)
  {
        return ERR_PTR(-ENODEV);
  }
-
-static inline int of_drm_get_panel_orientation(const struct device_node *np,
-                                              enum drm_panel_orientation 
*orientation)
-{
-       return -ENODEV;
-}
  #endif
#if defined(CONFIG_DRM_PANEL) 

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)

Reply via email to