Amit Barzilai <[email protected]> writes: Hello Amit,
> Javier Martinez Canillas <[email protected]> writes: >> Sorry, I was on PTO and couldn't take a look to your series. I plan to do >> it this week. > > Thank you for the update and there is no need to apologize. > >> One question, though. How did you find these issues and came up with the >> fixes ? >> >> It was just reading the code and the datasheets or were the issues (and >> fixes?) identified by an LLM? If the latter, then you need to add an >> Assisted-by tag to your pa+tches. > > I found the bug and solution while debugging the ssd1351 extention to ssd130x. > I used an LLM to make sure my patches made sense and to recheck my patch > logically > and I wasn't sure whether that was enough to warrant the tag. That's a good question. I don't really know to be honest. If was only to review your manually written changes then I guess there's no need to add the tag. > I'll submit a v2 of this series with the tag - let me know if you'd prefer it > handled > differently. > Up to you. As said, I don't know were we draw the line so I will let you decide if you want a v2 with the tags. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
