Hi, On Sun, Jun 28, 2026 at 6:28 PM <[email protected]> wrote: > > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) > to consider: > - [Medium] The panel name string in `EDP_PANEL_ENTRY` does not match the > actual hardware EDID, breaking the primary identity match. > -- > > commit 0f4c5c953c19a29919cb343c3bc25a2803059da7 > Author: Haikun Zhou <[email protected]> > drm/panel-edp: Support MB116AS01-3 edp panel > > This commit adds support for the HKC MB116AS01-3 eDP panel to the generic > panel-edp driver. It introduces the necessary delay configuration and EDID > identifiers for this display. > > > diff --git a/drivers/gpu/drm/panel/panel-edp.c > > b/drivers/gpu/drm/panel/panel-edp.c > > --- a/drivers/gpu/drm/panel/panel-edp.c > > +++ b/drivers/gpu/drm/panel/panel-edp.c > > @@ -2099,6 +2099,7 @@ static const struct edp_panel_entry edp_panels[] = { > > > > EDP_PANEL_ENTRY('E', 'T', 'C', 0x0000, > > &delay_50_500_e200_d200_po2e335, "LP079QX1-SP0V"), > > > > + EDP_PANEL_ENTRY('H', 'K', 'C', 0x1203, &delay_200_500_e80, > > "MB116AS01-3"), > > [Severity: Medium] > Does the panel name string in this entry match the actual hardware EDID? > > Looking at the raw EDID payload provided in the commit message: > 00 4d 42 31 31 36 41 53 30 31 27 33 20 20 01 cb > > The byte 0x27 translates to an apostrophe ('), which makes the hardware name > "MB116AS01'3" rather than "MB116AS01-3" (which would use a hyphen, 0x2d). > > Because drm_edid_match() strictly compares this string against the EDID > payload using strncmp(), this character mismatch will cause the primary > identity match to fail during panel probe. While the code will currently fall > back to a secondary panel ID match, this completely bypasses the primary name > matching mechanism designed to distinguish panels when vendors incorrectly > reuse panel IDs.
Please fix the AI's review feedback and send a v2. -Doug
