Amit Barzilai <[email protected]> writes: Hello Amit,
Thanks for your patches. > While working on adding SSD1351 support to the ssd130x driver - I > noticed that the area of the cursor was refreshing in a weird state. > I would fill the screen red while the flashing cursor was on the screen, > but the screen wouldn't refresh the entire 8x8 rectangle each flash. > > After reading the SSD1351, SSD1331 and SSD132x manuals and manual > testing on the SSD1351, I was able to be sure that the problem was the > end addresses of "Set Column/Row Address" being sent as relative addresses > instead of absolute addresses. > Indeed. > I assume these bugs went under the radar because testing would usually > be done where the dirty rectangles would start from the 0,0 coordinates. > In these situations, the bug would be invisable, since adresses relative > to 0 are the same as their absolute value. > Yes, I believe that was the case. Thanks a lot for fixing these issues! > It is important to note that I didn't test these changes on a SSD132x > scree0n or a SSD133x screens, only on an SSD1351. Manual testing is > advised. > > This series contains the fix for ssd132x_update_rect, a simple clean-up > patch for ssd132x_update_rect to keep the function clean, and the same > fix on ssd133x_update_rect. > For the whole series: Reviewed-by: Javier Martinez Canillas <[email protected]> I plan to push them to drm-misc-next rather than to drm-misc-fixes, since these have been long standing bugs and the changes are likely to conflict with your SSD1351 patches that are in-flight. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
