Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues: - [High] I2C read performed before enabling the chip via GPIO. -- commit 9b2c49c6b957cfe305a408b8c9b3c4052b039334 Author: Junjie Cao <[email protected]> backlight: aw99706: Validate all DT property values consistently The lookup helpers for dim-mode and ramp-ctl take a shortcut when lookup_tbl is NULL: they accept any u32 value without range-checking and return success unconditionally. Out-of-range values get silently truncated by regmap_update_bits instead of triggering the dev_warn + default-fallback path that the other properties use. > diff --git a/drivers/video/backlight/aw99706.c > b/drivers/video/backlight/aw99706.c > index e130f164303a2..dfb4b38b5b4c7 100644 > --- a/drivers/video/backlight/aw99706.c > +++ b/drivers/video/backlight/aw99706.c [ ... ] [Severity: High] This is a pre-existing issue, but while reviewing this driver I noticed a potential issue in aw99706_probe(). Does the driver attempt to read the chip ID before enabling the device? drivers/video/backlight/aw99706.c:aw99706_probe() { ... ret = aw99706_chip_id_read(aw); if (ret != AW99706_ID) return dev_err_probe(dev, -ENODEV, "Unknown chip id 0x%02x\n", ret); aw99706_dt_parse(aw, &props); aw->hwen_gpio = devm_gpiod_get(aw->dev, "enable", GPIOD_OUT_LOW); ... } If the bootloader leaves the chip disabled, would this I2C read fail or time out because the enable GPIO is not fetched and asserted until later in the probe sequence? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
