The fan re-scheduling logic sits inside an "if (target != duty)" block, so by the time the inner if/else-if chain runs, duty can never equal target. The "else if (duty == target)" branch is therefore dead code and has been since it was introduced. Drop it; the two reachable cases (duty > target and duty < target) are unchanged, so behaviour is identical.
Signed-off-by: Anas Khan <[email protected]> --- drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c index f8fa43c8a7d2..c4aaf7473065 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c @@ -90,8 +90,6 @@ nvkm_fan_update(struct nvkm_fan *fan, bool immediate, int target) if (duty > target) delay = slow_down_period; - else if (duty == target) - delay = min(bump_period, slow_down_period) ; else delay = bump_period; -- 2.54.0
