On 01/07/2026 19:18, Alessio Belle wrote:
Hi Ben,
On Mon, 2026-06-29 at 11:05 +0000, Alessio Belle wrote:
On Tue, 2026-06-23 at 11:53 +0100, Ben Dooks wrote:
The pvr_fw_trace_init_mask_ops is not used outside pvr_fw_trace.c
so make it static to avoid the following sparse warning:
drivers/gpu/drm/imagination/pvr_fw_trace.c:74:31: warning: symbol
'pvr_fw_trace_init_mask_ops' was not declared. Should it be static?
Signed-off-by: Ben Dooks <[email protected]>
Reviewed-by: Alessio Belle <[email protected]>
Actually, could you add a Fixes tag pointing at c6978643ea1c ("drm/imagination:
Validate fw trace group_mask")? You can then add the Reviewed-by tag as well for
last.
Thanks,
Alessio
ok, done
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
