Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Low] Missing default values for `solomon,width` and `solomon,height` in the binding schema. - [Low] Malformed Git trailer in the commit message (`Assisted-by: Claude:claude-opus-4-8`). --
commit 1fc812656be731d6e9e5623e968e630de22b7e48 Author: Amit Barzilai <[email protected]> dt-bindings: display: Add Solomon SSD1351 OLED controller This commit adds a device tree binding for the Solomon SSD1351 OLED display controller. The binding builds on the shared solomon,ssd-common.yaml properties. > Assisted-by: Claude:claude-opus-4-8 [Severity: Low] This isn't a bug, but this Git trailer does not follow the standard format `Tag: Full Name <[email protected]>`. Without an email address enclosed in angle brackets, this will likely trigger checkpatch warnings. > diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml > b/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml > new file mode 100644 > index 0000000000000..80850c2ab5b3e > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml [ ... ] > +allOf: > + - $ref: solomon,ssd-common.yaml# > + > +properties: > + compatible: > + enum: > + - solomon,ssd1351 [Severity: Low] Should there be default values defined for `solomon,width` and `solomon,height` in this block? Since the common schema `solomon,ssd-common.yaml` indicates these defaults are controller-dependent, omitting them here leaves the hardware's default resolution undocumented in this schema. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
