On 06/07/2026 17:31, Alessio Belle wrote:
Hi Ben,
On Fri, 2026-07-03 at 17:23 +0100, Ben Dooks wrote:
The pvr_fw_trace_init_mask_ops is not used outside pvr_fw_trace.c
so make it static to avoid the following sparse warning:
drivers/gpu/drm/imagination/pvr_fw_trace.c:74:31: warning: symbol
'pvr_fw_trace_init_mask_ops' was not declared. Should it be static?
Fixes: c6978643ea1c ("drm/imagination: Validate fw trace group_mask")?
nit: the "?" at the end
Revied-by: Alessio Belle <[email protected]>
nit: Revied-by -> Reviewed-by
I can fixup these manually after applying the patch, if you are fine with it,
unless you prefer to send a v3.
Planning to apply this patch to drm-misc-fixes by the end of this week.
Please go ahead and fixup the issues before applying.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
