Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The patch uses `FIELD_PREP_CONST` (and earlier patches in the series use `FIELD_PREP`) without explicitly including `<linux/bitfield.h>`. --
--- Patch [9]: [PATCH v2 09/12] phy: phy-mtk-dp: Rewrite and document default driving param macros --- commit e682fc4989b37eaa003ac03d4d2a9a69b306a63b Author: AngeloGioacchino Del Regno <[email protected]> phy: phy-mtk-dp: Rewrite and document default driving param macros This commit rewrites the default driving parameters for the PHY using FIELD_PREP_CONST. It also adds definitions and comments to explain what these parameters are supposed to set. > diff --git a/drivers/phy/mediatek/phy-mtk-dp.c > b/drivers/phy/mediatek/phy-mtk-dp.c > index d0ef8e8f6670c..9a800d6b91c3f 100644 > --- a/drivers/phy/mediatek/phy-mtk-dp.c > +++ b/drivers/phy/mediatek/phy-mtk-dp.c > @@ -85,51 +85,47 @@ [ ... ] > +#define XTP_LN_TX_LCTXC_SW2_PRE1 GENMASK(5, 0) > +#define XTP_LN_TX_LCTXC_SW3_PRE0 GENMASK(13, 8) > + > +#define BUILD_DRIVING_PARAM_0(sw0_pre0, sw0_pre1, sw0_pre2, sw0_pre3) ( > \ > + FIELD_PREP_CONST(XTP_LN_TX_LCTXC_SW0_PRE0, sw0_pre0) | \ [Severity: Low] This isn't a bug, but should linux/bitfield.h be explicitly included since this code now uses FIELD_PREP_CONST? Relying on implicit inclusions can cause build breakages in the future if a header like linux/phy/phy.h or linux/regmap.h stops including it. > + FIELD_PREP_CONST(XTP_LN_TX_LCTXC_SW0_PRE1, sw0_pre1) | \ > + FIELD_PREP_CONST(XTP_LN_TX_LCTXC_SW0_PRE2, sw0_pre2) | \ > + FIELD_PREP_CONST(XTP_LN_TX_LCTXC_SW0_PRE3, sw0_pre3) \ > +) -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=9
