Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The schema inadvertently allows `dmas` and `dma-names` properties for the `fsl,imx6ul-lcdif` compatible string. --
--- Patch [3]: [PATCH 3/4] dt-bindings: display: lcdif: Allow display0 child node for i.MX6UL --- commit 4b641f03375f74e811e7a58ce3d750c19709f1d5 Author: Frank Li <[email protected]> dt-bindings: display: lcdif: Allow display0 child node for i.MX6UL The legacy i.MX6UL LCDIF binding uses a display0 child node to describe the attached display. This commit updates the binding schema to allow this child node for fsl,imx6ul-lcdif. > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > index 2dd0411ec6516..2b123ddf06841 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -182,6 +182,7 @@ allOf: > contains: > enum: > - fsl,imx28-lcdif > + - fsl,imx6ul-lcdif > then: > properties: > dmas: false [Severity: Medium] Does this inadvertently allow dmas and dma-names properties for the fsl,imx6ul-lcdif compatible string? By adding fsl,imx6ul-lcdif to this combined exemption block, it appears to successfully bypass the legacy display restrictions to allow display0, but it also exempts the i.MX6UL from the dmas restrictions which were correctly applied prior to this patch. If a device tree incorrectly defines dmas properties on an fsl,imx6ul-lcdif node, dtbs_check might now silently pass without triggering a schema violation warning. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=3
