Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The mediatek,mt6893-disp-wdma compatible string is incorrectly placed in the standalone enum block, preventing it from using the mediatek,mt8173-disp-wdma fallback. --
--- Patch [9]: [PATCH v2 09/10] dt-bindings: display: mediatek: wdma: Add compatibles for more SoCs --- commit f57f0fa27efb2b4a343645baf41ff18e654a1717 Author: AngeloGioacchino Del Regno <[email protected]> dt-bindings: display: mediatek: wdma: Add compatibles for more SoCs This commit adds missing device tree compatible strings for the Write DMA hardware on several MediaTek SoCs. It specifically targets the Dimensity 1200 and the Kompanio 500/520/820/1200 series. > diff --git > a/Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.yaml > b/Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.yaml > index 97d052b0fb614..c3ed867d058d9 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.yaml > @@ -22,11 +22,16 @@ properties: > compatible: > oneOf: > - enum: > + - mediatek,mt6893-disp-wdma [Severity: Medium] Is mediatek,mt6893-disp-wdma incorrectly placed in this standalone enum block? Placing it here prevents it from using the mediatek,mt8173-disp-wdma fallback string. Because the MediaTek DRM driver only matches mediatek,mt8173-disp-wdma, Device Trees for the MT6893 will either break driver probing if they follow this schema strictly, or fail validation if they include the fallback string to allow the driver to probe. Should this compatible string be placed in the items block below with the other SoCs instead? > - mediatek,mt8173-disp-wdma > - items: > - enum: > - mediatek,mt6795-disp-wdma > - mediatek,mt8167-disp-wdma > + - mediatek,mt8183-disp-wdma > + - mediatek,mt8186-disp-wdma > + - mediatek,mt8192-disp-wdma > + - mediatek,mt8195-disp-wdma > - const: mediatek,mt8173-disp-wdma -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=9
