Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Removing `sram-supply` from the global `required` list makes it optional for `rockchip,rk3588-rknn-core`, incorrectly weakening schema validation for existing RK3588 hardware. --
--- Patch [1]: [RFC PATCH 1/9] dt-bindings: npu: rockchip: add rockchip,rk3576-rknn-core --- commit 9a2dabf1434398eb090f8e36b12d42467c86de03 Author: Jiaxing Hu <[email protected]> dt-bindings: npu: rockchip: add rockchip,rk3576-rknn-core This commit documents the RK3576 NPU core by adding the new compatible string rockchip,rk3576-rknn-core. It also drops sram-supply from the global required list since the RK3576 has no NPU SRAM supply. > diff --git > a/Documentation/devicetree/bindings/npu/rockchip,rk3588-rknn-core.yaml > b/Documentation/devicetree/bindings/npu/rockchip,rk3588-rknn-core.yaml > index caca2a4903cd1..d904db3bf9281 100644 > --- a/Documentation/devicetree/bindings/npu/rockchip,rk3588-rknn-core.yaml > +++ b/Documentation/devicetree/bindings/npu/rockchip,rk3588-rknn-core.yaml [ ... ] > @@ -75,7 +76,6 @@ required: > - resets > - reset-names > - npu-supply > - - sram-supply [Severity: Medium] By dropping sram-supply from the global required list to accommodate the RK3576, does this incorrectly weaken schema validation for existing RK3588 hardware? If an RK3588 device tree node is missing the sram-supply property, it appears it will now silently pass make dtbs_check validation. Could this instead use an allOf block with an if-then conditional to enforce the sram-supply requirement specifically when the compatible string is rockchip,rk3588-rknn-core? > > additionalProperties: false -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
