Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Redefining `endpoint` with `unevaluatedProperties: false` locally masks properties evaluated by the sibling `$ref: '#/$defs/lvds-port'`, causing valid TI-specific LVDS properties to be improperly rejected. --
--- Patch [2]: [PATCH v5 2/3] dt-bindings: display: sn65dsi83: Add output data-lanes property --- commit c64bd236e14a70bf7062c9fee49e33ef3475908b Author: Wojciech Dubowik <[email protected]> dt-bindings: display: sn65dsi83: Add output data-lanes property Add an optional output LVDS data lanes property with two allowed values for standard and reversed layouts. The reversed layout informs the driver that the reverse LVDS config option must be set for the respective output channel. > diff --git > a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > index e69b6343a8ebb..4000bf0b13709 100644 > --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > @@ -86,10 +86,54 @@ properties: > description: Video port for LVDS Channel-A output (panel or bridge). > $ref: '#/$defs/lvds-port' > > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false [Severity: Medium] Will this unevaluatedProperties constraint cause valid properties inherited from the sibling '$ref: '#/$defs/lvds-port'' reference to be improperly rejected? Since unevaluatedProperties is scoped only to this inline schema, it cannot see annotations from the lvds-port definition. If a device tree file defines port@2 with both data-lanes and properties like ti,lvds-termination-ohms, could this result in a validation failure when running make dtbs_check? [ ... ] > port@3: > description: Video port for LVDS Channel-B output (panel or bridge). > $ref: '#/$defs/lvds-port' > > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false [Severity: Medium] Similar to port@2 above, could this locally scoped unevaluatedProperties: false block reject valid properties inherited from the lvds-port definition on port@3? > + > + properties: > + data-lanes: > + $ref: /schemas/types.yaml#/definitions/uint32-array -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
