The TODO describes "a number of spots here that manually acquire/release the DMA reservation lock using dma_resv_(un)lock()", but no such spots exist in this file.
The only `dma_resv` reference left is the `base.resv` assignment in `Object::new()`, which takes no lock. The manual locking the comment refers to does exist in `GpuVmBoAlloc::obtain()` in rust/kernel/drm/gpuvm/vm_bo.rs, which already carries its own equivalent note, so nothing is lost by removing this one. Signed-off-by: Maurice Hieronymus <[email protected]> --- rust/kernel/drm/gem/shmem.rs | 5 ----- 1 file changed, 5 deletions(-) diff --git a/rust/kernel/drm/gem/shmem.rs b/rust/kernel/drm/gem/shmem.rs index 34af402899a0..3c1d75b54c2c 100644 --- a/rust/kernel/drm/gem/shmem.rs +++ b/rust/kernel/drm/gem/shmem.rs @@ -4,11 +4,6 @@ //! //! C header: [`include/linux/drm/drm_gem_shmem_helper.h`](srctree/include/drm/drm_gem_shmem_helper.h) -// TODO: -// - There are a number of spots here that manually acquire/release the DMA reservation lock using -// dma_resv_(un)lock(). In the future we should add support for ww mutex, expose a method to -// acquire a reference to the WwMutex, and then use that directly instead of the C functions here. - use crate::{ container_of, drm::{ --- base-commit: 7059bdf4f04a3e14f4fafb3ac35fdca913e3e21a change-id: 20260718-rust-drm-shmem-stale-todo-c7be5ee8beb0 Best regards, -- Maurice Hieronymus <[email protected]>
