Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The commit message explicitly claims to resolve kernel-doc warnings for the `flags` and `id` members of `struct drm_ethosu_perfmon_set_global`, but the patch entirely omits adding the corresponding documentation. --
--- Patch [1]: [PATCH v3] accel: Arm Ethos-U NPU: fix most uapi kernel-doc warnings --- commit 0321c04e286a508fa979adef1d2ae1df38206a86 Author: Randy Dunlap <[email protected]> accel: Arm Ethos-U NPU: fix most uapi kernel-doc warnings This commit updates the kernel-doc comments in the ethosu_accel uapi header to resolve several documentation warnings. It adds missing struct member descriptions and corrects prototype names. > Warning: include/uapi/drm/ethosu_accel.h:230 struct member 'perfmon_id' not > described in 'drm_ethosu_submit' > Warning: include/uapi/drm/ethosu_accel.h:274 struct member 'flags' not > described in 'drm_ethosu_perfmon_set_global' > Warning: include/uapi/drm/ethosu_accel.h:274 struct member 'id' not described > in 'drm_ethosu_perfmon_set_global' > > Signed-off-by: Randy Dunlap <[email protected]> [Severity: Medium] Does this patch accidentally omit the documentation updates for flags and id? The commit message mentions resolving the warnings for drm_ethosu_perfmon_set_global, but the actual changes do not appear in the diff. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
