Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Compilation error due to function signature mismatch in KUnit test --
--- Patch [3]: [PATCH v4 03/11] drm/vkms: Add KUnit test for YCbCr to RGB conversion matrices --- commit dd6b42b44f3cdb2524b236663ae684d8ead8a59a Author: Harry Wentland <[email protected]> drm/vkms: Add KUnit test for YCbCr to RGB conversion matrices The existing yuv_u16_to_argb_u16 test performs a full RGB->YCbCr->RGB round trip with a tolerance of 0x1ff. This patch adds a parameterised test that checks the exact S31.32 fixed-point coefficients and luma offset returned by get_conversion_matrix_to_argb_u16() against reference values. > diff --git a/drivers/gpu/drm/vkms/tests/vkms_format_test.c > b/drivers/gpu/drm/vkms/tests/vkms_format_test.c > index 789c59d07ffb6..e746b18bf37b0 100644 > --- a/drivers/gpu/drm/vkms/tests/vkms_format_test.c > +++ b/drivers/gpu/drm/vkms/tests/vkms_format_test.c [ ... ] > +static void vkms_format_test_conversion_matrix(struct kunit *test) > +{ > + const struct conversion_matrix_case *param = test->param_value; > + struct conversion_matrix matrix; > + > + get_conversion_matrix_to_argb_u16(DRM_FORMAT_NV12, param->encoding, > + param->range, false, &matrix); [Severity: Low] Will this compile when the VKMS KUnit tests are enabled? The newly added test code calls get_conversion_matrix_to_argb_u16() with 5 arguments, passing false as the 4th argument. However, the function signature in vkms_formats.h only accepts 4 arguments, which will cause a 'too many arguments to function' compiler error. > + > + for (size_t i = 0; i < 3; i++) { > + for (size_t j = 0; j < 3; j++) { > + KUNIT_EXPECT_EQ_MSG(test, matrix.matrix[i][j], > + param->expected.matrix[i][j], > + "matrix[%zu][%zu] mismatch for %s - > %s", > + i, j, > + > drm_get_color_encoding_name(param->encoding), > + > drm_get_color_range_name(param->range)); > + } > + } > + > + KUNIT_EXPECT_EQ(test, matrix.y_offset, param->expected.y_offset); > +} -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=3
