Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The newly introduced `EDID_QUIRK_IGNORE_STEREO_FLAG` quirk is never assigned to any panel in the `edid_quirk_list`, making the added logic dead code. --
--- Patch [1]: [PATCH 1/2] drm: add a EDID_QUIRK_IGNORE_STEREO_FLAG quirk --- commit c12c9b1e2a3442319892a911d6fc20a3c6916841 Author: Michał Szolc <[email protected]> drm: add a EDID_QUIRK_IGNORE_STEREO_FLAG quirk This commit introduces a new EDID quirk meant to ignore the stereo flag for screens that misrepresent certain modes. > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 07970e5b5f65e..4720217f99bff 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -96,6 +96,8 @@ enum drm_edid_internal_quirk { > EDID_QUIRK_NON_DESKTOP, > /* Cap the DSC target bitrate to 15bpp */ > EDID_QUIRK_CAP_DSC_15BPP, > + /* Ignore stereo flag of modes */ > + EDID_QUIRK_IGNORE_STEREO_FLAG, > }; > > #define MICROSOFT_IEEE_OUI 0xca125c [ ... ] > @@ -3538,7 +3540,8 @@ static struct drm_display_mode > *drm_mode_detailed(struct drm_connector *connecto > if (hactive < 64 || vactive < 64) > return NULL; > > - if (pt->misc & DRM_EDID_PT_STEREO) { > + if (pt->misc & DRM_EDID_PT_STEREO && > + !drm_edid_has_internal_quirk(connector, > EDID_QUIRK_IGNORE_STEREO_FLAG)) { [Severity: Medium] Is this new quirk missing an entry in the edid_quirk_list[] array? Because the quirk is internal to drm_edid.c and isn't currently mapped to any specific vendor or product IDs in edid_quirk_list[], the call to drm_edid_has_internal_quirk() will unconditionally evaluate to false. This makes the newly introduced logic unreachable. Should a specific display panel be added to edid_quirk_list[] in this patch to utilize the fix? > drm_dbg_kms(dev, "[CONNECTOR:%d:%s] Stereo mode not > supported\n", > connector->base.id, connector->name); > return NULL; -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
