Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The newly added `DRM_WEDGE_RECOVERY_COLD_RESET` recovery method is not documented in the UAPI documentation. --
--- Patch [1]: [PATCH v12 1/4] drm: Add DRM_WEDGE_RECOVERY_COLD_RESET recovery method --- commit 1acdd09ef42a2d7b1fde40c873937c144a20b544 Author: Mallesh Koujalagi <[email protected]> drm: Add DRM_WEDGE_RECOVERY_COLD_RESET recovery method This commit introduces a new recovery method, DRM_WEDGE_RECOVERY_COLD_RESET, to handle scenarios requiring a device power cycle. It adds the "cold-reset" string mapping and the corresponding bit flag. > diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c > index 1ff0bf7cba6aa..94abe7a811a52 100644 > --- a/drivers/gpu/drm/drm_drv.c > +++ b/drivers/gpu/drm/drm_drv.c > @@ -537,6 +537,8 @@ static const char *drm_get_wedge_recovery(unsigned int > opt) > return "bus-reset"; > case DRM_WEDGE_RECOVERY_VENDOR: > return "vendor-specific"; > + case DRM_WEDGE_RECOVERY_COLD_RESET: > + return "cold-reset"; [Severity: Medium] Should this new recovery method be documented in Documentation/gpu/drm-uapi.rst? Looking at Documentation/gpu/drm-uapi.rst, there is a table mapping recovery methods to consumer expectations: =============== ======================================== Recovery method Consumer expectations =============== ======================================== none optional telemetry collection rebind unbind + bind driver bus-reset unbind + bus reset/re-enumeration + bind vendor-specific vendor specific recovery method unknown consumer policy =============== ======================================== Could "cold-reset" be missing from this UAPI documentation, leaving userspace developers without a canonical reference for its expected consumer policies? > default: > return NULL; > } -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
