Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The patch replaces `drm_bridge_connector_force()` with `drm_bridge_connector_force_ctx()` and calls `drm_atomic_helper_connector_hdmi_force_ctx()`. However, `drm_atomic_helper_connector_hdmi_force_ctx()` is neither defined nor declared anywhere in the kernel tree. This results in an implicit function declaration error and undefined reference during linking. --
--- Patch [18]: [PATCH v10 18/69] drm/display: bridge_connector: Switch to .force_ctx() connector helper --- commit 01a7e2cca1b495d499fd78712842111769ad4146 Author: Cristian Ciocaltea <[email protected]> drm/display: bridge_connector: Switch to .force_ctx() connector helper This commit replaces the drm_bridge_connector_force() function with a .force_ctx() implementation. It hands the acquire context over to drm_atomic_helper_connector_hdmi_force_ctx() for HDMI connectors. > diff --git a/drivers/gpu/drm/display/drm_bridge_connector.c > b/drivers/gpu/drm/display/drm_bridge_connector.c > --- a/drivers/gpu/drm/display/drm_bridge_connector.c > +++ b/drivers/gpu/drm/display/drm_bridge_connector.c [ ... ] > @@ -322,6 +311,19 @@ static int drm_bridge_connector_detect_ctx(struct > drm_connector *connector, > return status; > } > > +static int drm_bridge_connector_force_ctx(struct drm_connector *connector, > + struct drm_modeset_acquire_ctx *ctx) > +{ > + struct drm_bridge_connector *bridge_connector = > + to_drm_bridge_connector(connector); > + struct drm_bridge *hdmi = bridge_connector->bridge_hdmi; > + > + if (hdmi) > + return drm_atomic_helper_connector_hdmi_force_ctx(connector, > ctx); [Severity: Low] It appears drm_atomic_helper_connector_hdmi_force_ctx() is not declared anywhere in the kernel tree prior to being used here. Could this result in an implicit function declaration error and an undefined reference during linking when building with DRM display bridge connector support enabled? Is it possible a prerequisite patch introducing this helper was omitted from the series? > + > + return 0; > +} > + [ ... ] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=18
