Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The macro MAX_HDMI_TMDS_CHAR_RATE_HZ is left unused after its only caller was removed. --
--- Patch [51]: [PATCH v10 51/69] drm/bridge: ite-it6263: Advertise HDMI 1.3 capabilities --- commit bc899868425793b3c769c7eaa96a7d6bb7256b3c Author: Cristian Ciocaltea <[email protected]> drm/bridge: ite-it6263: Advertise HDMI 1.3 capabilities This commit advertises HDMI 1.3 support for the IT6263 bridge and sets the max_tmds_char_rate limit. It also drops the hdmi_tmds_char_rate_valid() hook since its checks are now handled earlier by the DRM core. > diff --git a/drivers/gpu/drm/bridge/ite-it6263.c > b/drivers/gpu/drm/bridge/ite-it6263.c > index 550999491086e..e8e0197171e10 100644 > --- a/drivers/gpu/drm/bridge/ite-it6263.c > +++ b/drivers/gpu/drm/bridge/ite-it6263.c [ ... ] > @@ -738,20 +738,6 @@ it6263_bridge_atomic_get_input_bus_fmts(struct > drm_bridge *bridge, > return input_fmts; > } > > -static enum drm_mode_status > -it6263_hdmi_tmds_char_rate_valid(const struct drm_bridge *bridge, > - const struct drm_display_mode *mode, > - unsigned long long tmds_rate) > -{ > - if (mode->clock > MAX_PIXEL_CLOCK_KHZ) > - return MODE_CLOCK_HIGH; > - > - if (tmds_rate > MAX_HDMI_TMDS_CHAR_RATE_HZ) > - return MODE_CLOCK_HIGH; [Severity: Low] Since this function is being removed, does this leave MAX_HDMI_TMDS_CHAR_RATE_HZ as dead code? Looking at drivers/gpu/drm/bridge/ite-it6263.c, the macro is defined near the top of the file: #define MAX_HDMI_TMDS_CHAR_RATE_HZ 225000000 but it doesn't appear to be used anywhere else in the driver now. Could it be removed in this patch as well? > - > - return MODE_OK; > -} -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=51
