Komeda currently decodes GLB_CORE_ID with bit definitions that do not match the hardware register layout, which leads to incorrect hardware version reporting.
Patch 1 fixes the GLB_CORE_ID field definitions so the reported product version matches the hardware specification. DRM clone-mask validation can reject Komeda display + writeback configurations because the encoder pair attached to one CRTC does not advertise the required reciprocal possible_clones relationship. Patch 2 sets the display/writeback clone masks when the writeback connector is created, making the clone relationship explicit for the encoder pair attached to that CRTC. Changes in v2: - Patch 1: add a short GLB_CORE_ID layout comment and drop the redundant product-id mask and shift-by-zero change noted in review. - Patch 2: replace the global encoder mask initialization with per-CRTC display/writeback clone-mask setup. - Patch 2: include each encoder's own bit in possible_clones. - Update patch 2 subject and cover letter text to match the localized fix. Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Signed-off-by: Raveendra Talabattula <[email protected]> Raveendra Talabattula (1): drm/komeda: Fix bits parsing of GLB_CORE_ID Vincenzo Frascino (1): drm/komeda: Set display/writeback clone masks .../drm/arm/display/include/malidp_product.h | 10 +++++++--- .../arm/display/komeda/komeda_wb_connector.c | 33 +++++++++++++++++++ 2 files changed, 40 insertions(+), 3 deletions(-) -- 2.43.0
