On 8/4/26 15:52, Christoph Hellwig wrote:
On Mon, Aug 03, 2026 at 02:16:33PM +0200, David Hildenbrand (Arm) wrote:
+EXPORT_SYMBOL(__vmf_insert_pfn_prot);
If this becomes a dedicated symbol, why not GPL?
Yes, no way we'd not export low-level bits like this as non-GPL..
David requested to turn the simpler functions such as vmf_insert_pfn()
from separate exports to static inlines. For the v2 that I have just
posted, that's what I did. I can either use EXPORT_SYMBOL_GPL() or
switch to inlines, but not both because functions like vmf_insert_pfn()
are currently EXPORT_SYMBOL().
Also, this function specifically is basically the same as
vmf_insert_pfn_prot(), which is already exported as non GPL, but there's
really no logic at all as to what is EXPORT_SYMBOL() and what is
EXPORT_SYMBOL_GPL(). vmf_insert_pfn_prot() mucks with pgprot_t and is
much lower level than vmf_insert_page_mkwrite()... but it's the latter
that is GPL.
Paolo
