Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] `pramin_mut` is missing the `pub(crate)` visibility modifier, making it private to the `mm` module. --
--- Patch [10]: [PATCH 10/12] gpu: nova-core: mm: Add GpuMm centralized memory manager --- commit 0abff5539341f15cd592232acd203deec02947c6 Author: Joel Fernandes <[email protected]> gpu: nova-core: mm: Add GpuMm centralized memory manager This commit introduces GpuMm as a centralized GPU memory manager in the nova-core driver. It initially owns the PRAMIN window for direct VRAM access and provides an accessor method for use by follow-on patches. It also updates the static info parsing to compute the total FB end. [ ... ] > diff --git a/drivers/gpu/nova-core/mm.rs b/drivers/gpu/nova-core/mm.rs > index ef5b1cad56c31..58dce211a3373 100644 > --- a/drivers/gpu/nova-core/mm.rs > +++ b/drivers/gpu/nova-core/mm.rs [ ... ] > + /// Access the [`pramin::Pramin`]. > + fn pramin_mut(&mut self) -> &mut pramin::Pramin<'gpu> { [Severity: Medium] The commit message states that this provides an accessor method so follow-on patches can reference pramin_mut() cleanly. However, without a pub(crate) visibility modifier, won't this method be private to the mm module? Will this prevent other modules from calling it as intended, and potentially trigger a dead_code compiler warning? > + &mut self.pramin > + } > +} [ ... ] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=10
