Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Low] The binding title inaccurately describes all variants as '2 Port', despite the newly added LT9611C being a 1-port device. - [Low] The commit message contains a typo that changes the meaning and makes the sentence difficult to understand: 'Receiver signal/dual port' instead of 'receives single/dual port'. --
--- Patch [1]: [PATCH v10 1/2] dt-bindings: bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver --- commit 289235c0c9457d9357c713f43f18d3182cc0f7d7 Author: Sunyun Yang <[email protected]> dt-bindings: bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver This commit updates the Lontium LT9611 bridge bindings to add support for the LT9611C, LT9611EX, and LT9611UXD variants. It adds the new compatible strings and enforces a single-port configuration specifically for the LT9611C. > LT9611C(EX/UXD) is an I2C-controlled chip that Receiver signal/dual port > mipi dsi and output hdmi, differences in hardware features: [Severity: Low] This isn't a bug, but there appear to be a few typos in this description. Would it be clearer to rephrase "Receiver signal/dual port" to "receives single/dual port"? > diff --git > a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml > b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml > index 429a06057ae85..194aeaac601f3 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml > @@ -4,19 +4,23 @@ > $id: http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Lontium LT9611(UXC) 2 Port MIPI to HDMI Bridge > +title: Lontium LT9611(UXC/C/EX/UXD) 2 Port MIPI DSI to HDMI Bridge [Severity: Low] This isn't a bug, but does the "2 Port" descriptor still apply to all the variants listed here? Since the LT9611C is described in the commit message as a 1-port device and its second port is correctly disabled later in this schema, retaining "2 Port" in the overall title might cause some confusion. [ ... ] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
