On Sat, Aug 08, 2026 at 01:03:52AM -0400, Guodong Xu wrote: > On 2026-07-27 09:35, Philipp Zabel wrote: > > On Sa, 2026-07-25 at 00:51 -0400, Cody Kang via B4 Relay wrote: > > > From: Cody Kang <[email protected]> > > > > > > + /* > > > + * Assert before gating: a reset asserted into an already-gated block > > > + * has no clock edges to propagate on and leaves the register file > > > + * untouched. > > > + */ > > > + dpu_reset_assert(dev, "lcd", a_crtc->lcd_reset); > > > + dpu_reset_assert(dev, "esc", a_crtc->esc_reset); > > > + dpu_reset_assert(dev, "mclk", a_crtc->mclk_reset); > > > > It looks like these three are mirrored, and could be handled by > > reset_control_bulk_assert/deassert(). > > > > > + dpu_reset_assert(dev, "aclk", a_crtc->aclk_reset); > > > + dpu_reset_assert(dev, "dsc", a_crtc->dsc_reset); > > Is there a reason these two cannot be mirrored in order? Please double > check. As I checked the vendor tree, the suspend/resume side appear to be > copy/paste rather than a deliberate ordering. > > Please double-check. Unless I'm missing something, I suggest to bulk them.
Agree, I'll check. Cody
