On Tue, Aug 4, 2026 at 4:28 AM Krzysztof Kozlowski <[email protected]> wrote: > > On 04/08/2026 13:24, Sean Rhodes wrote: > > On Tue, 4 Aug 2026 at 12:05, Krzysztof Kozlowski > > <[email protected]> wrote: > >> > >> On 04/08/2026 13:02, Krzysztof Kozlowski wrote: > >>> On 04/08/2026 12:13, Sean Rhodes wrote: > >>>> rename to drivers/firmware/coreboot/Kconfig > >>>> index b78c644fa253..d273bd836245 100644 > >>>> --- a/drivers/firmware/google/Kconfig > >>>> +++ b/drivers/firmware/coreboot/Kconfig > >>>> @@ -1,13 +1,16 @@ > >>>> # SPDX-License-Identifier: GPL-2.0-only > >>>> -menuconfig GOOGLE_FIRMWARE > >>>> - bool "Google Firmware Drivers" > >>>> +menuconfig COREBOOT_FIRMWARE > >>> > >>> As pointed out by defconfig change, which is supposed to be separate > >>> commit, this will affect users of the kernel for no real gain. > >>> > >>> Do not change this. > >> > >> I am surprised that such change appeared at v10. > >> > >> Changelog is quite incomplete and I do not see any explanation for this. > > > > Sorry, don't follow - so put the names back, or split it into its own patch? > > I did not find explanation of this in the changelog. It cuts at v9, so > maybe that's the reason, although lore pointed me the v10 as the first > version introducing new CONFIG symbols. > > Anyway, IMO renaming is really not worth if the sole reason is Google > name is disliked now.
Krzysztof, the idea with this change was to introduce the new Kconfig symbols that more accurately represent the new directory structure while keeping the old symbol names available as fallback symbols for people who continue using old .config files. Doesn't that avoid the pain to users you're concerned about? I thought doing renames like this cleanly was the whole point of the `transitional` feature in the Kconfig language. Why do we have that lever if we don't want to use it for the kind of cases it was meant for?
