On Wed, Aug 12, 2026 at 05:28:50PM +0300, Dmitry Baryshkov wrote: > On Wed, Aug 12, 2026 at 03:51:16PM +0200, Manivannan Sadhasivam wrote: > > On Wed, May 13, 2026 at 09:14:05PM +0300, Dmitry Baryshkov wrote: > > > Replace fixed value configuration tables with the values calculated at > > > the runtime. In some cases the values might differ from the original > > > values. Those were validated on the IFC6410 board. > > > > > > Signed-off-by: Dmitry Baryshkov <[email protected]> > > > > One nit below. With that fixed, > > > > Acked-by: Manivannan Sadhasivam <[email protected]> > > > > > --- > > > drivers/phy/qualcomm/phy-qcom-hdmi-28lpm.c | 325 > > > +++++++++-------------------- > > > 1 file changed, 104 insertions(+), 221 deletions(-) > > > > > > -static const struct pll_rate *qcom_hdmi_8960_pll_find_rate(unsigned long > > > rate) > > > +static inline void write16(u16 val, void __iomem *reg) > > > > No 'inline' keyword in .c files please. > > Why? >
Because the modern compilers are smarter enough to decide whether a specific function should be inlined or not. There is no guarantee that the 'inline' keyword that you pass will be honored by the compiler also, it is just a hint. That's why it is preferred to drop 'inline' keyword from .c files to avoid churn and leave the judgement to the compilers. - Mani -- மணிவண்ணன் சதாசிவம்
